dbremner / blurip

Automatically exported from code.google.com/p/blurip
0 stars 0 forks source link

Foreign PGS subs missing language flag #15

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Select any foreign (i.e. not English) subtitle in a M2TS.
2. Select mux all PGS subtitles.
3. Do a remux.

What is the expected output? What do you see instead?
Only English PGS subs will have a language flag. IDX/SUB subtitles will have 
language flag on all subtitles.
The subtitles without language flag will still work but it's annoying to not 
have a language flag, instead it says "Undetermined/Unknown" in players.

What version of the product are you using? On what operating system?
-blurip_svn142 & blurip051
-Win7

Original issue reported on code.google.com by chhe...@gmail.com on 30 Nov 2010 at 2:24

GoogleCodeExporter commented 8 years ago
Only subtitles/audio tracks with a language tag that is in preferred language 
list will get a language tag in mkv.
Try to add the missing languages in the preferred subtitles language list.
I will try to add something to set the language for tracks with no preferred 
language.

Original comment by hawk...@gmx.net on 3 Dec 2010 at 8:19

GoogleCodeExporter commented 8 years ago
Ah ok, I thought the "preferred language list" was just for selecting what 
languages will be auto selected when loading the M2TS. Specially since all 
IDX/SUB subtitles get a langauge flag.

Original comment by chhe...@gmail.com on 3 Dec 2010 at 10:13

GoogleCodeExporter commented 8 years ago
Yes, the preferred language list is for auto select. But it is also used to get 
the language iso tag (e.g. 'en' or 'de').
The latest commit includes a search for the iso tag for any language.
Will upload a new svn build later.

Original comment by hawk...@gmx.net on 3 Dec 2010 at 10:46

GoogleCodeExporter commented 8 years ago
Thanks for the quick fix.

Original comment by chhe...@gmail.com on 3 Dec 2010 at 8:51

GoogleCodeExporter commented 8 years ago
I did a test. "Modern Greek" doesn't seem to get a language flag.

Original comment by chhe...@gmail.com on 3 Dec 2010 at 10:36

GoogleCodeExporter commented 8 years ago
I tried with "Robin Hood":

Text #1
ID                               : 4
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Deutsch

Text #2
ID                               : 5
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Deutsch

Text #3
ID                               : 6
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Deutsch

Text #4
ID                               : 7
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs

Text #5
ID                               : 8
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs

Text #6
ID                               : 9
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Französisch

Text #7
ID                               : 10
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Italienisch

Text #8
ID                               : 11
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Spanisch

Text #9
ID                               : 12
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Katalanisch

Text #10
ID                               : 13
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Niederländisch/Holländisch

Text #11
ID                               : 14
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Chinesisch

Text #12
ID                               : 15
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Dänisch

Text #13
ID                               : 16
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Finnisch

Text #14
ID                               : 17
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Isländisch

Text #15
ID                               : 18
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Koreanisch

Text #16
ID                               : 19
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Norwegisch Bokmål

Text #17
ID                               : 20
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Portugiesisch

Text #18
ID                               : 21
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Schwedisch

Text #19
ID                               : 22
Format                           : PGS
Codec-ID                         : S_HDMV/PGS
Codec-ID/Info                    : The same subtitle format used on BDs/HD-DVDs
Sprache                          : Chinesisch

It worked for all subtitle tracks. Track 4 & 5 are english - this isn't 
displayed in MediaInfo.

Maybe you can send me the complete log?

Original comment by hawk...@gmx.net on 4 Dec 2010 at 11:20

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
"Track 4 & 5 are english - this isn't displayed in MediaInfo."
What do you mean? Do they have a language flag in players then? English subs 
are displayed in my MediaInfo at least.

Here's a remux with "Modern Greek" missing the language flag. Every other 
language seems to work so far.

MediaInfo: http://pastebin.ca/2010825
Main log: http://pastebin.ca/2010827
Sub log: http://pastebin.ca/2010828

A bit offtopic, though I don't get why those forced subs are created (aka 
extracted from the original sub I guess). The Spanish sub only contains "FIN" 
at the end, the French one contains a couple more lines.

Original comment by chhe...@gmail.com on 5 Dec 2010 at 1:22

GoogleCodeExporter commented 8 years ago
I did two more remuxes and this time the English sub had no language flag in 
MediaInfo, it showed up fine as "English" sub in players though.

Original comment by chhe...@gmail.com on 9 Dec 2010 at 9:45