MSFT incompatibilities with dbt-adapter-tests

dbt-labs / dbt-adapter-tests

a pytest plugin for dbt adapter test suites

19 stars 11 forks source link

MSFT incompatibilities with dbt-adapter-tests #7

Closed dataders closed 4 years ago

dataders commented 4 years ago

see this draft PR: https://github.com/fishtown-analytics/dbt/pull/2790 not sure how to make this work without changing dbt-core... would love some ideas on workarounds: both short- and long-term.

jtcohen6 commented 4 years ago

Right on, @swanderz. We implemented timestamp_add_sql and get_rows_different_sql as adapter methods for exactly this reason, so that you can override them in plugins.

See:

BigQuery redefines timestamp_add_sql here and adapts get_rows_different_sql here
Spark redefines get_rows_different_sql here

dataders commented 4 years ago

passing all the adapter tests now (except for incremental & ephemeral, which we haven't touched yet)!

jtcohen6 commented 4 years ago

Thanks for testing this out @swanderz!! I'm going to open issues in a bunch more repos :))