[CT-2413] [Bug] Non-functional testing for `string_type` and `numeric_type` static class methods

dbeatty10 commented 1 year ago

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Based on the documentation for the string_type static class method here, we'd expect the following query to work across adapters:

select cast(10 as {{ api.Column.string_type(4000) }})

But a package maintainer reported here that it doesn't work for dbt-bigquery, dbt-spark, or dbt-databricks.

Expected Behavior

See above.

Steps To Reproduce

See here for steps to reproduce.

Which database adapter are you using with dbt?

bigquery, spark

Suspected root cause

The primary testing for these two methods appears tautological to me (rather than actually testing platform-specific data types).

Acceptance criteria

[ ] add functional tests for the string_type and numeric_type adapter class methods that adapter maintainers can inherit
[ ] inherit those new adapter tests for all adapters maintained by dbt Labs
[ ] add instructions for maintainer adapters in the next version migration guide
[ ] either update or remove these tests

github-actions[bot] commented 1 year ago

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

rlh1994 commented 1 year ago

Stale label - a haiku GitHub actions bot Please do not close this issue It still needs a fix

dbeatty10 commented 1 year ago

Your words have been heard, Stale label swept away, friend, Gratitude expressed

github-actions[bot] commented 3 months ago

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

github-actions[bot] commented 3 months ago

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

dbt-labs / dbt-adapters