dbt-labs / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
https://dbt-athena.github.io
Apache License 2.0
225 stars 96 forks source link

[Bug] Comment on post-hook vacuum, optimize operations #704

Closed sanromeo closed 2 months ago

sanromeo commented 2 months ago

Is this a new bug in dbt-athena?

Current Behavior

14:46:11 On model.data_models.table1: vacuum "awsdatacatalog"."sandbox_roman_korsun"."table1" -- / {"app": "dbt", "dbt_version": "1.8.1", "profile_name": "athena", "target_name": "local" /

Expected Behavior

14:46:11 On model.data_models.table1: vacuum "awsdatacatalog"."sandbox_roman_korsun"."table1"

Steps To Reproduce

Write vaccum or optimize query in post-hook and run model with configured post-hook

Environment

- OS: -
- Python: 3.11.7
- dbt: 1.8.1
- dbt-athena-community: 1.8.3 (main branch)

Additional Context

No response

nicor88 commented 2 months ago

@sanromeo isn't this a consequence of this PR https://github.com/dbt-athena/dbt-athena/pull/702? looks like that the comment it's added, but for optimize and vacuum shouldn't be added.

sanromeo commented 2 months ago

@nicor88 yes, that are consequences of my previous PR, so I've created one more #705