dbt-labs / dbt-jsonschema

Apache License 2.0
118 stars 40 forks source link

dbt_project.yml does not recognize boolean #156

Open taylorterwin opened 1 month ago

taylorterwin commented 1 month ago

Screenshot 2024-08-16 at 9 57 15 AM

Configurations stemming from https://hub.getdbt.com/tnightengale/dbt_meta_testing/latest/ implementing the required_docs and required_tests configuration.

taylorterwin commented 1 month ago

Noting: user is on versionless + Snowflake

dave-connors-3 commented 1 month ago

thanks for the issue @taylorterwin! I think this is due to the fact that we don't currently have any package-specific configs supported out of the box here. I'll circle with @joellabes, but not sure we'd want to get in the business of trying to accommodate every config from every package!

joellabes commented 1 month ago

I think https://github.com/dbt-labs/dbt-jsonschema/issues/68 is discussing the way we would go about this if we did want to go about it!

Even then, I would have thought we'd have wanted to hide them inside the config dict instead of letting them roam free 🤔

joellabes commented 1 month ago

One of the big problems here is that if we open up to allow alternative properties, a lot of the autocomplete plugins stop offering autocomplete because they don't know if you're trying to type one of the defined properties or add something outside of our known list.