dbt-labs / dbt-postgres

Apache License 2.0
22 stars 12 forks source link

remove tests covered by dbt-core #147

Closed MichelleArk closed 1 week ago

MichelleArk commented 1 week ago

resolves #N/A docs dbt-labs/docs.getdbt.com/#

Problem

From testing in https://github.com/dbt-labs/dbt-postgres/actions/runs/10775130606:

tests/functional/adapter/test_debug.py: 8 warnings
tests/functional/adapter/test_empty.py: 1 warning
tests/functional/minimal_cli/test_minimal_cli.py: 3 warnings
tests/functional/test_dbt_runner.py: 5 warnings
tests/functional/test_init.py: 5 warnings
tests/functional/test_multiple_indexes.py: 1 warning
...
tests/functional/deprecations/test_config_deprecations.py FFFFF....      [ 38%]

Solution

tests/functional/adapter/test_debug.py -> actually an adapter test tests/functional/adapter/test_empty.py -> actually an adapter test tests/functional/minimal_cli/test_minimal_cli.py -> should exclusively be a dbt-core test tests/functional/test_dbt_runner.py -> should exclusively be a dbt-core test tests/functional/test_init.py -> should exclusively be a dbt-core test (don't even think an adapter gets loaded for this one) tests/functional/test_multiple_indexes.py -> dbt-postgres specific test tests/functional/deprecations/test_config_deprecations.py -> should be dbt-core only, and drift introduced in https://github.com/dbt-labs/dbt-core/pull/10670

Checklist

github-actions[bot] commented 1 week ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-postgres contributing guide.