dbt-labs / dbt-project-evaluator

This package contains macros and models to find DAG issues automatically
https://dbt-labs.github.io/dbt-project-evaluator/latest/
Apache License 2.0
451 stars 68 forks source link

Should all tests be changed to data_tests? #505

Open BradCr opened 1 month ago

BradCr commented 1 month ago

Describe the feature

While building a model from this project, I see a warning message about tests being deprecated soon.

$ dbt compile --select fct_model_directories
19:16:47  Running with dbt=1.8.7
19:16:48  [WARNING]: Deprecated functionality
The `tests` config has been renamed to `data_tests`. Please see https://docs.getdbt.com/docs/build/data-tests#new-data_tests-syntax for more
information.

The tests aren't actually going to be deprecated, but using tests is no longer the best practice and we should use data_tests instead.

My question is, should we change all the tests in this project to be data_tests? Even if the warning message disappears in a future version of dbt-core, I think we want this package to follow the best practices.

Describe alternatives you've considered

Haven't considered anything else.

Additional context

None.

Who will this benefit?

Users running the dbt-project-evaluator won't see these warning messages, and anyone who examines the code for this package will see it conforms to best practices.

Are you interested in contributing this feature?

Yes, I can make this change if it is needed.