[Bug] Use fully qualified names in rename for tables and views - Githubissues

dbt-labs / dbt-snowflake

dbt-snowflake contains all of the code enabling dbt to work with Snowflake

https://getdbt.com

Apache License 2.0

297 stars 177 forks source link

[Bug] Use fully qualified names in rename for tables and views #1060

Closed mikealfare closed 5 months ago

mikealfare commented 6 months ago

resolves #1031

Problem

The rename macro for tables and views uses only the identifier. It's expected to use the fully qualified name.

Solution

Update these macros to incorporate the new name into the source relation, thereby preserving the database and schema.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX