add a test to reach this code path that calls str(), fix bugs

dbt-labs / hologram

A library for automatically generating Draft 7 JSON Schemas from Python dataclasses

MIT License

9 stars 13 forks source link

add a test to reach this code path that calls str(), fix bugs #33

Closed beckjake closed 4 years ago

beckjake commented 4 years ago

Almost nothing actually calls str() on validation errors from unvalidated json (hence the perf improvement...), but if you did, 0.0.9 had a couple bugs. I got so excited by the performance I didn't notice this!

I don't think this is reachable from anywhere in dbt, because we always validate unless we made the data in the first place, but I can imagine this coming up.