search

dcfemtech / hackforgood-waba-map

DCFemTech Hack for Good 2016 - WABA Bike Map Project
MIT License
10 stars 9 forks source link

Code style - consistently use single quotes #80

Closed alulsh closed 8 years ago

alulsh commented 8 years ago

@tomBeach switched from single to double quotes for site.js in https://github.com/dcfemtech/hackforgood-waba-map/pull/78.

Doesn't matter which quote we use as long as we are consistent.

I'm going to update the .eslintrc to use double quotes instead of single quotes so that npm test passes.

alulsh commented 8 years ago

Looks like some parts of the codebase use single quotes whereas others use double quotes - we'll need to get this to be consistent.

I vote for single quotes. Someone needs to switch the code in sites.js to use only single quotes.

alulsh commented 8 years ago

Fixed in https://github.com/dcfemtech/hackforgood-waba-map/pull/84 🎉 !

Big thanks to @seongju 🙇 !