search

ddanelynn / pe

0 stars 0 forks source link

Display success message even though there is no change for edit meeting #12

Open ddanelynn opened 3 years ago

ddanelynn commented 3 years ago

When the field keyed in is same as original, a success mesage is displayed. Similar to editp, the product should notify users that the keyed in details are the same as original.

the meeting before change:

Screenshot 2021-04-16 at 2.53.52 PM.png

commmand: editm 1 n/CS2103 Lecture

result:

Screenshot 2021-04-16 at 2.54.10 PM.png

nus-pe-bot commented 3 years ago

Team's Response

Thank you for the suggestion. However, this is not a bug.

Editing a meeting to put in the same information still counts as editing the meeting. We see no value in handling this as a special case.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It should be at least stated in the docs that editing allows fields to be the same as the original fields to justify that this is not a bug. However, there is no such justification in the docs, and hence it should be considered as a bug as a product should be able to handle all corner cases.