Open ddanelynn opened 3 years ago
Thank you for the comment.
We do enforce some small restrictions on the entered email, but we did not choose to be so strict. Rigorously checking the email's validity is beyond the scope of the project in its current form.
Furthermore, this is something very minor and does not affect the user experience, so we have lowered the severity.
Team chose [response.NotInScope
]
Reason for disagreement: I believe email validation is a serious issue and should be handled by developers. This is especially so when the purpose of this part of the product is to keep track of people's contact information. User tend to directly copy-paste the information from the contact list, and if the email entered is not even in the correct format, it will cause problems for users.
Team chose [severity.Low
]
Originally [severity.Medium
]
Reason for disagreement: [replace this with your explanation]
Maybe it will be better to detect invalid email format command keyed in:
addp n/Betsy Crowe g/CS2103 e/betsycrowe@example..com a/Newgate Prison ph/1234567 g/badmi