search

dddshelf / ddd-in-php-book-issues

Leave your comments, improvements or book mistakes as an issue! Thanks ❤️
https://leanpub.com/ddd-in-php
28 stars 2 forks source link

Uncredited excerpt from Martin Fowler #77

Closed marcverney closed 7 years ago

marcverney commented 7 years ago

The Metaphor section at the beginning of the Domain events chapter is clearly a copy/paste from Martin Fowler´s Domain events page dddinphp-domain-events-fowler

This text should be presented to the reader as a quote, and credited to its original author.

keyvanakbary commented 7 years ago

Wow! Nasty, we rely a lot on original quotes by brilliant authors and this is totally unfair. It totally went unnoticed. I just fixed it, should be already available in Leanpub 👍

You are already in the Acknowledgements so I can't add you again. Thanks a lot!

marcverney commented 7 years ago

Keyvan, your change from two weeks ago does not seem to be reflected in LeanPub. Nothing has changed there.

keyvanakbary commented 7 years ago

Facepalm, I forgot to hit the button “publish new version”. Now is available to download, I checked it myself.

Thanks for the heads up! 👍

marcverney commented 7 years ago

Ok I see it now. I was not aware that this same text was in POEAA too, though. I saw it on Fowler's website, only with slight differences.