Closed rfay closed 11 months ago
Please confirm correctness @julienloizelet @tyler36
I also implemented this in ddev-platformsh
Thanks @rfay ,
defaults
part : https://github.com/ddev/ddev-addon-template/blob/f1d038d8ed87bf48baa7ce0998ce5343ec0ac36e/.github/workflows/tests.yml#L28-L30We already set bash as shell in every step of the action because it is required to define one : https://github.com/ddev/github-action-add-on-test/blob/main/action.yaml#L63 for example
env
part https://github.com/ddev/ddev-addon-template/blob/f1d038d8ed87bf48baa7ce0998ce5343ec0ac36e/.github/workflows/tests.yml#L22-L24The DDEV_GITHUB_TOKEN value is already set in the action: https://github.com/ddev/github-action-add-on-test/blob/main/action.yaml#L98-L100
There's no harm in keeping it, but :
token
input value.ddev get
without reaching the API rate limit (It doesn't prove anything, but it suggests that it works.). See what you think now @julienloizelet - thanks for paying careful attention.
The Issue
We now have the lovely github-action-add-on-test from @julienloizelet - THANKS!
This uses it.