ddev / ddev-addon-template

Template for DDEV add-ons.
Apache License 2.0
17 stars 17 forks source link

ci: use github action for bulk of github test #31

Closed rfay closed 11 months ago

rfay commented 1 year ago

The Issue

We now have the lovely github-action-add-on-test from @julienloizelet - THANKS!

This uses it.

rfay commented 1 year ago

Please confirm correctness @julienloizelet @tyler36

I also implemented this in ddev-platformsh

julienloizelet commented 1 year ago

Thanks @rfay ,

We already set bash as shell in every step of the action because it is required to define one : https://github.com/ddev/github-action-add-on-test/blob/main/action.yaml#L63 for example

The DDEV_GITHUB_TOKEN value is already set in the action: https://github.com/ddev/github-action-add-on-test/blob/main/action.yaml#L98-L100

There's no harm in keeping it, but :

rfay commented 1 year ago

See what you think now @julienloizelet - thanks for paying careful attention.