search

ddev / ddev-redis

Redis service for DDEV
Apache License 2.0
23 stars 8 forks source link

Add removal_action to remove settings.ddev.redis.php on add-on removal #15

Closed rfay closed 1 year ago

rfay commented 1 year ago

The Issue

In DDEV v1.22.0+ there is a removal_actions section of the install.yaml, specifically for things like what this add-on does, adding settings config into sites/default.

How This PR Solves The Issue

Do the cleanup of sites/default/settings.ddev.redis.php on removal

Manual Testing Instructions

On a drupal site:

ddev get https://github.com/rfay/ddev-redis/tarball/20230720_post_removal_action Verify that sites/default/settings.ddev.redis.php exists ddev get --remove redis

You should have no sites/default/settings.ddev.redis.php any more.

Make sure it doesn't break on DDEV v1.22.6 (which should ignore that extra section)

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

rfay commented 1 year ago

Manually tested with v1.21.6 and v1.22.0, all seems to work correctly.