ddev / github-action-setup-ddev

Set up your GitHub Actions workflow with DDEV
GNU General Public License v3.0
33 stars 7 forks source link

Support installing a specific ddev version #13 #20

Closed deviantintegral closed 10 months ago

deviantintegral commented 10 months ago

The Issue

See https://github.com/ddev/github-action-setup-ddev/issues/13 and https://github.com/jonaseberle/github-action-setup-ddev/issues/15.

How This PR Solves The Issue

If version is specified, we pass that to apt and then hold the package so upgrades won't automatically upgrade it.

Manual Testing Instructions

    - name: Install ddev
      uses: deviantintegral/github-action-setup-ddev@set-ddev-version
      with:
        autostart: false
        version: 1.22.3

Automated Testing Overview

This adds a matrix to test both cases for version.

jonaseberle commented 10 months ago

This looks and feels very good, thank you @deviantintegral! Any objections to merge and release v1.9?

deviantintegral commented 10 months ago

Not from me! We've been using this for nearly a week to work around https://github.com/orgs/ddev/discussions/5470.

jonaseberle commented 10 months ago

v1.9.0 is released with this. Thanks!