ddev / vscode-ddev-manager

DDEV Manager offers a centralized and user-friendly interface to control every aspect of your DDEV projects.
https://marketplace.visualstudio.com/items?itemName=biati.ddev-manager
Apache License 2.0
12 stars 3 forks source link

FR: Display "Mail" under services #2

Closed tyler36 closed 10 months ago

tyler36 commented 10 months ago

Is your feature request related to a problem? Please describe. Thank you for the great extension, I've only been playing with for about 30 minutes but it's super! I think it would be convienient to have a way to open the "Mail" service.

Describe the solution you'd like I would like to see "Mail" under services, with an icon to open in the browser. Clicking the icon, should open the current mail service in a browser, similar to ddev launch -m functionality. Not sure if this is already there somewhere but I couldn't find it.

Additional context DDEV <=1.22.1 use Mailhog as the mail service. There is an open PR request to replace MailHog with Mailpit; a different service with the same functionality and launch shortcut. Perhaps call the service "Mail", instead of "MailHog" (current) or "Mailpit" (1.23 ?) would keep the name consistent regardless of version.

I am current running ddev version v1.22.1-58-g3a427fd30 (PR preview version mentioned above).

biati-digital commented 10 months ago

Hi, I'm glad you like the extension.

That's already possible, in fact any service that provides a URL can be opened with the extension.

In the sidebar in the services list just move the mouse over mailhog and you'll see the action to launch it, other devices have different actions like PHP, MySQL, etc. you can also open mailhog using the command palette.

biati-digital commented 10 months ago

I read your message again, I think changing Mailhog or Mailpit to simply "Mail" it's a good idea, users moving from other tools will find it easier and know exactly what it is, at the end must of the users do not care if its Mailpit or mailhog, they just want to test emails.

I like it, I'll do the change.

biati-digital commented 10 months ago

mmmmm.... With your current version are you able to see the Mailhog service listed in the sidebar?

CleanShot 2023-09-04 at 10 31 30 (I've changed the name to Mail)

I believe there's a bug with the current version of the extension, in my dev extension I see the Mail service but not in the extension published in the marketplace.

Anyway, I've made the change. I checked the PR you mention and added support for Mailpit, later when DDEV replaces Mailhog the extension will continue to work without problems. I'll publish an update soon.

rfay commented 10 months ago

Just FYI Mailhog/Mailpit aren't separate Docker "services". They're additional processes running inside the web container.

So is php-fpm

So is Node.js, but it's not normally "running" there

The database service is in fact a service, and if phpmyadmin is installed, it's a service.

biati-digital commented 10 months ago

Hi @rfay understood. I'll move NodeJS, PHP and Mail outside of services and display them with the other information. Just to be consistent on how DDEV works. Are you ok with using the label Mail instead of Mailhog or Mailpit?

CleanShot 2023-09-04 at 11 10 12

rfay commented 10 months ago

Maybe it would be better to use something like "Mail Catcher" or something? Not sure. It's actually the web UI that you're pointing to right?

rfay commented 10 months ago

I guess "Mail Catcher" isn't going to work; that's an alternate project. Just "Mail" should be OK for now.

biati-digital commented 10 months ago

Yes, clicking that will open the web UI for the selected project. I'll use "Mail" for now. 👍

biati-digital commented 10 months ago

@rfay So "Mail Catcher" is out of the question? I think just "Mail" looks a little weird as the label of each item is getting shorter and all I see is that, not sure if it's just me. Or maybe using "Mail: Mailhog" or "Mail: Mailpit" or any other alternative like "SMTP Catcher"?

CleanShot 2023-09-04 at 13 03 44

CleanShot 2023-09-04 at 12 59 19 CleanShot 2023-09-04 at 13 00 31 CleanShot 2023-09-04 at 13 09 40

rfay commented 10 months ago

A lot of people don't know what "SMTP" means. "Mail UI" ?

tyler36 commented 10 months ago

That's already possible, in fact any service that provides a URL can be opened with the extension.

On DDEV 1.22.1 I can see Mailhog, but do not DDEV 1.22.1-58-g3a427fd30 (DDEV Manager 1.0.1)

Yes, clicking that will open the web UI for the selected project. I'll use "Mail" for now.

"Mail UI" also works for me, if you think "Mail" is strange.

I'll move NodeJS, PHP and Mail outside of services and display them with the other information. Just to be consistent on how DDEV works.

I really like this. 👍

biati-digital commented 10 months ago

There's a new update that includes this and other changes. CHANGELOG

About the "Mail" label, for now I'm using "Mail UI". I tend to be really picky about certain details of interfaces so I added a hidden setting just for myself to be able to change that text, I'll share it here just in case you want to try other alternatives:

"ddevManager.sidebarLabels": {
    "email": "Mail Catcher",
  }

I've created a "Roadmap" just to share the things that I want to do/or remember that need to be added and also to share what I'm working on.