ddevault / TrueCraft

Minecraft for hipsters
http://truecraft.io/
MIT License
2.4k stars 312 forks source link

Add list command #237

Closed Peroalane closed 8 years ago

ddevault commented 8 years ago

Does this match the output of the vanilla server's implementation of the same command?

Peroalane commented 8 years ago

Yes, according to the wiki.

http://minecraft.gamepedia.com/Commands#list

Peroalane commented 8 years ago

With the exception of the UUID stuff.

ddevault commented 8 years ago

I mean that I'm not sure that "Current online players: " is present on the official server, nor do I really like it. Another concern is: what if the list of players is longer than the maximum length of a chat message? You'll need to split it up.

Peroalane commented 8 years ago

I'll change it a bit then.

Peroalane commented 8 years ago

What is the maximum length?

ddevault commented 8 years ago

I don't recall, google it.

Peroalane commented 8 years ago

Okay to merge now?

ddevault commented 8 years ago

I would prefer that you sent multiple chat messages that were, individually, no longer than the maximum length, rather than just not sending the list if there are too many players.

Peroalane commented 8 years ago

Me too, but at least the command works :) There's no harm in merging it.

ddevault commented 8 years ago

That's not how it works.