search

ddialliance / DdiToCogs

Convert DDI 3.x schemas to a Cogs data model
MIT License
0 stars 0 forks source link

Choices not implemented #2

Open spuddybike opened 4 years ago

spuddybike commented 4 years ago
spuddybike commented 4 years ago

Open question what should the UML look like? @spuddybike

wlthomas commented 3 years ago

ERROR: Cardinality in choice was taken from elements rather than choice tag RULE: take cardinality from the choice element NOT from sub-elements Item/reference pairs: 108 items changed from maxOccurs unbounded to maxOccurs 1 in CSV (took cardinality from item not choice element) AggregationType: contains a 1..1 choice of AggrationVariable and AggregationVariableReference. Under current cardinality rules should result in a 0..1 AggregationVariableReference.

SPECIFIC PROBLEMS: SummaryStatisticType [should be solved by use of relaxed cardinality rule. 0..1 for each. There was no reason for a 1..1 on the choice]

ConditionalResultType ControlConstructType [should be resolved by using the cardinality of the choice element for 0..n choice equals 0..n individual elements] ControlConstructGroupType [should be resolved by using the cardinality of the choice element for 0..n choice equals 0..n individual elements] GirdAttachmentType [should be resolved by using the cardinality of the choice element for 0..n choice equals 0..n individual elements] QuesionGridType [FIRST CHOICE: interior handled by ITEM/Reference rule; outer should use 0..1 to 0..1 with documentaton] [SECOND CHOICE: should be resolved by using the cardinality of the choice element for 0..n choice equals 0..n individual elements] QualityStatementType [INTERNAL CHOICE: resolved by 0..1 option for QualityStandardReference] [PRIMARY CHOICE: 0..1 of each with documentation] RepresentedVariableType [FRST CHOICE: each element should be 0..1 with documentation on equivilencies ConceptualVariable = UnitType + Concept] [SECOND choice: reference items only 0..1 with documentation] ContributorType [UNIQUE: 0..1 of each element] TargetObjectType [UNIQUE: change to AgencyOrganizationReference which supports either Organization or Individual] TargetRepresentationType [Needs remodelling - actually all should be Managed Representations but should include base representations and managed representations rather than the building blocks] DateType [REMOCEL: to include a simpledate, startdate, and enddate each with ISO and Historical (non-ISO date) with documentation on use. Include cycle as a 0..1 option in startdate] OPTION [provide added documentation]
spuddybike commented 3 years ago

generic taking choice from element rather than choice tag moved to issue #6

spuddybike commented 3 years ago

For these bespoke changes, DONT convert to COGS, but pick them up as individual problems by hand in DDI Model