search

dealii / code-gallery

A collection of codes based on deal.II contributed by deal.II users
Other
44 stars 54 forks source link

Add Python version of the benchmark. #97

Closed bangerth closed 2 years ago

bangerth commented 2 years ago

The promised follow-up to #96 with the Python code. I'll put the Matlab version up in a separate PR.

bangerth commented 2 years ago

To make everyone's life simpler, I added the Matlab version here as well.

@davidaristoff: FYI

bangerth commented 2 years ago

Ping?

bangerth commented 2 years ago

@davidaristoff Can you take a look at these suggestions? If you make these changes in your repository, I will pull the latest code from there and make corresponding changes to the python version.

marcfehling commented 2 years ago

@davidaristoff Can you take a look at these suggestions? If you make these changes in your repository, I will pull the latest code from there and make corresponding changes to the python version.

It's really just renaming one or two variables and some layout suggestions :)

davidaristoff commented 2 years ago

Do I have to approve a pull request? I'm not really familiar with Github...

bangerth commented 2 years ago

No. In this case, I created this pull request using the software I had pulled from your repo. Once you tell me that I should get the version from your repo again, I will do so, update the version shown here, and someone else will merge.

davidaristoff commented 2 years ago

Oh OK. Yes, the version on my repo is ready.

bangerth commented 2 years ago

I've imported @davidaristoff 's last version, and have made the corresponding changes in the python version. Any more comments?

marcfehling commented 2 years ago

I couldn't find a way to plot the solution in the python code. The Matlab implementation provides one.

Do you think such a feature would be nice for the python code?

bangerth commented 2 years ago

No, it's unimportant. If someone wants to do it, they can use the Matlab version, or they can add this feature later -- but it's not the point of the program as it stands right now. The point of the code is to provide a Python version to compute the posterior probability, nothing else.

bangerth commented 2 years ago

Ping?