debeshmandal / starpolymers

Simulation tools for LAMMPS system generation and analysis for polyelectrolyte condensation
MIT License
7 stars 2 forks source link

Different errors in rigid hexagon generation in python 3.7 & 3.8+ #22

Open shanilpanara opened 2 years ago

shanilpanara commented 2 years ago

On the dev-new-shapes branch, the following errors are recieved:

Tested with versions: 3.7.7 3.8.11 and 3.9.9:

image

debeshmandal commented 2 years ago

Thanks for this - I cannot recreate this issue. Can you run the following commands and screenshot the results here:

$ python --version
$ python -m pip --version
$ pip --version
$ python -m pip list | grep starpolymers
$ pip list | grep starpolymers
jakublala commented 2 years ago

Found the same issue on the pip released version of starpolymers.

The results from @debeshmandal's commands are for me as follows:

$ python --version
Python 3.9.7
$ python -m pip --version
pip 21.2.4 from C:\Users\jakub\anaconda3\envs\neuralode\lib\site-packages\pip (python 3.9)
$  pip --version
pip 21.2.4 from C:\Users\jakub\anaconda3\envs\neuralode\lib\site-packages\pip (python 3.9)
$ python -m pip list | grep starpolymers
starpolymers      2.1.0
$ pip list | grep starpolymers
starpolymers      2.1.0
shanilpanara commented 2 years ago

Partial fix

Commenting out line 39 in starpolymers/genrators/system.py

def __init__(self, ...):
    ...
    self.add_molecules(molecules)
    self.assert_neutral()
    #self.fix_overlap(threshold)
debeshmandal commented 2 years ago

@jakublala

You have the wrong version, it's an old version, the current version should be 2.1.0+21.g0ea17ee.dirty

Try reinstalling from source, if that doesn't work I will deploy a new version 2.2.0 to PyPI