search

debricked / cli

Debricked's command line interface. It brings open source security, compliance and health to your project via the command prompt.
MIT License
20 stars 10 forks source link

CLI is built with go 1.20, but apk add go install go 1.19 in Dockerfile #79

Closed emilwareus closed 1 year ago

emilwareus commented 1 year ago

In the multistage Dockerfile that is used to build the official release of the image there is a problem with go versions:

Under the first scope (FROM golang:1.20-alpine AS dev) go 1.20 is used, but under the second scope: 

FROM alpine:latest AS cli
...
RUN apk --no-cache --update add go

Alpine will resolve to go version 1.19 today.

It is probably good to be explicit about what version of go to install, rather than rely on whatever is distributed through Alpine right now.

This affects the resolution-cmd branch.

viktigpetterr commented 1 year ago

Thanks for letting me know! :+1: :blush:

viktigpetterr commented 1 year ago

Fixed in https://github.com/debricked/cli/pull/54/commits/1860ce6100079f55b737a632e6a8554087643b04