search

decidim / docker

Docker images for decidim
https://decidim.org
12 stars 18 forks source link

Add build for -test and -dev images to new workflow #62

Closed oliverbarnes closed 3 years ago

oliverbarnes commented 3 years ago

As noted by @tramuntanal in https://github.com/decidim/docker/issues/50#issuecomment-741692694_:

@oliverbarnes we must take into account that other repos are using *-test images to execute their test suites like https://github.com/AjuntamentdeBarcelona/decidim-barcelona, https://github.com/AjuntamentdeBarcelona/decidim-barcelona-organizations or https://github.com/AjuntamentdeBarcelona/decidim-barcelona

Hence the new flow should include the Dockerfile-test build to keep supporting this. Likewise there are probably developers depending on the Dockerfile-dev build as well, so we should add it too.

oliverbarnes commented 3 years ago

The merged build for decidim-test is failing when trying to install the decidim-dev gem:

Step 8/9 : RUN gem install decidim-dev:${decidim_version} --force
 ---> Running in 3ab3c60847bd
ERROR:  Could not find a valid gem 'decidim-dev:' (>= 0) in any repository
ERROR:  Possible alternatives: decidim-dev, decidim, decidim-admin, decidim-api, decidim-core
The command '/bin/sh -c gem install decidim-dev:${decidim_version} --force' returned a non-zero code: 2

Error: Process completed with exit code 2.

https://github.com/decidim/docker/runs/1590170446?check_suite_focus=true#step:9:32

I'm working on a fix.

oliverbarnes commented 3 years ago

Fixed on https://github.com/decidim/docker/pull/68.

New dev and test images are now up on both Docker Hub and Github Container Registry