search

decipher3114 / Revancify

The only revancify
Apache License 2.0
855 stars 61 forks source link

feat: Add more info to the output APK filename #65

Closed KobeW50 closed 5 months ago

KobeW50 commented 8 months ago

This PR aims to add the app name and version to the name of the APK which is saved to external storage. For example, instead of the patched APK being named base-ReX.apk, it may now be named ReX_YouTube_19.05.36.apk.

I have no experience with shell, and I cannot read the code or test it. I imagine that my changes are not enough and will cause issues because I did not take reverse compatibility into account. Please carefully review (and test) the code if you are able to. If not, just close this PR.

Closes https://github.com/decipher3114/Revancify/issues/28

ChrisMiller94 commented 4 months ago

Please check my opened issue here: https://github.com/decipher3114/Revancify/issues/88

It is very logical for naming, but unfortunately I'm not able to fix this.

@KobeW50 Are you figured it out which things need to be replaced?

@decipher3114 Please open a test or dev branch for testing purposes.

I'm really sure, you guys are able to think logical and fix my issue only with a few line code changes.

I'm able to test, if a test/dev branch will be available with a releated README for testing.

KobeW50 commented 4 months ago

Please check my opened issue here: #88

It is very logical for naming, but unfortunately I'm not able to fix this.

@KobeW50 Are you figured it out which things need to be replaced?

I agree that it would be a good change, but I am unfortunately not qualified to help. I can barely read code