search

decipher3114 / Revancify

The only revancify
Apache License 2.0
867 stars 61 forks source link

patching icon error #9

Closed Dy9nasty closed 1 year ago

Dy9nasty commented 1 year ago

i went to select the red icon for patching and it only gives me the blue icon. i had a friend test it to see if it was just me and it also happened to them. we both have the correct settings and source

Spacellary commented 1 year ago

Even when only custom-branding-icon-revancify-red is selected, the custom-branding-icon-revancify-blue is still applied instead.

Tested with a fresh new install of Revancify.

I have verified that this issue doesn't occur when using the CLI.jar and patching manually, this is only happening when using Revancify.

Using: Termux Monet v0.118.0-33 Source: ReVanced Extended Arch: arm64-v8a

decipher3114 commented 1 year ago

Please send me the patchlog

Spacellary commented 1 year ago

As of right now this issue isn't happening anymore as you can see in the new patch_log.txt, included and excluded patches match the selection. I can only assume it was either a usability error or issue when pressing the Save button.

patch_log.txt of when this seemed to happen:

Show/Hide ``` INFO: Reading dex files INFO: Loading resource table... INFO: Decoding AndroidManifest.xml only, because resources are not needed INFO: Loading resource table from file: revanced-cache/1.apk INFO: Skipping add-splash-animation: Excluded by default INFO: Skipping custom-branding-icon-mmt: Excluded by default INFO: Skipping custom-branding-icon-revancify-red: Excluded by default INFO: Skipping disable-landscape-mode: Excluded by default INFO: Skipping enable-debug-logging: Excluded by default INFO: Skipping force-hide-player-button-background: Excluded by default INFO: Skipping force-premium-heading: Excluded by default INFO: Skipping hide-double-tap-overlay-filter: Excluded by default INFO: Skipping materialyou: Excluded by default INFO: Merging inotia00-integrations-v0.115.1.apk INFO: Loading resource table... INFO: Deleting existing resource cache directory INFO: Decoding resources INFO: Decoding AndroidManifest.xml with resources... INFO: Loading resource table from file: revanced-cache/1.apk INFO: Regular manifest package... INFO: Decoding file-resources... INFO: Decoding values */* XMLs... INFO: Executing patches INFO: Bypass ambient mode restrictions succeeded INFO: Change homepage succeeded INFO: Custom branding YouTube name succeeded INFO: Custom branding icon Revancify blue succeeded INFO: Custom double tap length succeeded INFO: Custom package name succeeded INFO: Custom playback speed succeeded INFO: Custom seekbar color succeeded INFO: Default playback speed succeeded INFO: Default video quality succeeded INFO: Disable QUIC protocol succeeded INFO: Disable Shorts on startup succeeded INFO: Disable auto captions succeeded INFO: Disable haptic feedback succeeded INFO: Disable hdr video succeeded INFO: Disable pip notification succeeded INFO: Enable compact controls overlay succeeded INFO: Enable external browser succeeded INFO: Enable minimized playback succeeded INFO: Enable new comment popup panels succeeded INFO: Enable new splash animation succeeded INFO: Enable new thumbnail preview succeeded INFO: Enable old quality layout succeeded INFO: Enable open links directly succeeded INFO: Enable seekbar tapping succeeded INFO: Enable tablet mini player succeeded INFO: Enable tablet navigation bar succeeded INFO: Enable time stamps speed succeeded INFO: Enable wide search bar succeeded INFO: Force OPUS codec succeeded INFO: Force VP9 codec succeeded INFO: Header switch succeeded INFO: Hide account menu succeeded INFO: Hide auto player popup panels succeeded INFO: Hide autoplay button succeeded INFO: Hide autoplay preview succeeded INFO: Hide button container succeeded INFO: Hide captions button succeeded INFO: Hide cast button succeeded INFO: Hide category bar succeeded INFO: Hide channel avatar section succeeded INFO: Hide channel watermark succeeded INFO: Hide collapse button succeeded INFO: Hide comment component succeeded INFO: Hide crowdfunding box succeeded INFO: Hide description components succeeded INFO: Hide end screen cards succeeded INFO: Hide end screen overlay succeeded INFO: Hide feed flyout panel succeeded INFO: Hide filmstrip overlay succeeded INFO: Hide floating microphone succeeded INFO: Hide fullscreen panels succeeded INFO: Hide general ads succeeded INFO: Hide handle succeeded INFO: Hide info cards succeeded INFO: Hide latest videos button succeeded INFO: Hide layout components succeeded INFO: Hide load more button succeeded INFO: Hide mix playlists succeeded INFO: Hide music button succeeded INFO: Hide navigation buttons succeeded INFO: Hide navigation label succeeded INFO: Hide player button background succeeded INFO: Hide player flyout panel succeeded INFO: Hide player overlay filter succeeded INFO: Hide previous next button succeeded INFO: Hide quick actions succeeded INFO: Hide seek message succeeded INFO: Hide seekbar succeeded INFO: Hide shorts components succeeded INFO: Hide snack bar succeeded INFO: Hide speed overlay succeeded INFO: Hide suggested actions succeeded INFO: Hide suggested video overlay succeeded INFO: Hide suggestions shelf succeeded INFO: Hide time stamp succeeded INFO: Hide tooltip content succeeded INFO: Hide trending searches succeeded INFO: Hide video ads succeeded INFO: Language switch succeeded INFO: Layout switch succeeded INFO: MicroG support succeeded INFO: Optimize resource succeeded INFO: Overlay buttons succeeded INFO: Return YouTube Dislike succeeded INFO: Settings succeeded INFO: Sponsorblock succeeded INFO: Spoof app version succeeded INFO: Spoof player parameters succeeded INFO: Swipe controls succeeded INFO: Theme succeeded INFO: Translations succeeded INFO: Compiling resources INFO: Writing modified dex files INFO: Aligning base.apk to base-Revanced-Extended_aligned.apk INFO: Signing base-Revanced-Extended_aligned.apk to base-Revanced-Extended_signed.apk INFO: Found existing keystore: revancify.keystore INFO: Copying base-Revanced-Extended_signed.apk to base-Revanced-Extended.apk INFO: Cleaned up cache directory INFO: Finished Rooted: false Arch: arm64-v8a App: YouTube v18.30.37 CLI: inotia00-cli-v2.22.2.jar Patches: inotia00-patches-v2.187.1.jar Integrations: inotia00-integrations-v0.115.1.apk Patches argument: -i bypass-ambient-mode-restrictions -i change-homepage -i custom-branding-youtube-name -i custom-branding-icon-revancify-blue -i custom-double-tap-length -i custom-package-name -i custom-playback-speed -i custom-seekbar-color -i default-playback-speed -i default-video-quality -i disable-quic-protocol -i disable-shorts-on-startup -i disable-auto-captions -i disable-haptic-feedback -i disable-hdr-video -i disable-pip-notification -i enable-compact-controls-overlay -i enable-external-browser -i enable-minimized-playback -i enable-new-comment-popup-panels -i enable-new-splash-animation -i enable-new-thumbnail-preview -i enable-old-quality-layout -i enable-open-links-directly -i enable-seekbar-tapping -i enable-tablet-mini-player -i enable-tablet-navigation-bar -i enable-time-stamps-speed -i enable-wide-search-bar -i force-opus-codec -i force-vp9-codec -i header-switch -i hide-account-menu -i hide-auto-player-popup-panels -i hide-autoplay-button -i hide-autoplay-preview -i hide-button-container -i hide-captions-button -i hide-cast-button -i hide-category-bar -i hide-channel-avatar-section -i hide-channel-watermark -i hide-collapse-button -i hide-comment-component -i hide-crowdfunding-box -i hide-description-components -i hide-end-screen-cards -i hide-end-screen-overlay -i hide-feed-flyout-panel -i hide-filmstrip-overlay -i hide-floating-microphone -i hide-fullscreen-panels -i hide-general-ads -i hide-handle -i hide-info-cards -i hide-latest-videos-button -i hide-layout-components -i hide-load-more-button -i hide-mix-playlists -i hide-music-button -i hide-navigation-buttons -i hide-navigation-label -i hide-player-button-background -i hide-player-flyout-panel -i hide-player-overlay-filter -i hide-previous-next-button -i hide-quick-actions -i hide-seek-message -i hide-seekbar -i hide-shorts-components -i hide-snack-bar -i hide-speed-overlay -i hide-suggested-actions -i hide-suggested-video-overlay -i hide-suggestions-shelf -i hide-time-stamp -i hide-tooltip-content -i hide-trending-searches -i hide-video-ads -i language-switch -i layout-switch -i microg-support -i optimize-resource -i overlay-buttons -i return-youtube-dislike -i settings -i sponsorblock -i spoof-app-version -i spoof-player-parameters -i swipe-controls -i theme -i translations ```

patch_log.txt from a new build now:

Show/Hide ``` INFO: Reading dex files INFO: Loading resource table... INFO: Decoding AndroidManifest.xml only, because resources are not needed INFO: Loading resource table from file: revanced-cache/1.apk INFO: Skipping add-splash-animation: Excluded by default INFO: Skipping custom-branding-icon-mmt: Excluded by default INFO: Skipping custom-branding-icon-revancify-blue: Excluded by default INFO: Skipping disable-landscape-mode: Excluded by default INFO: Skipping enable-debug-logging: Excluded by default INFO: Skipping force-hide-player-button-background: Excluded by default INFO: Skipping force-premium-heading: Excluded by default INFO: Skipping hide-double-tap-overlay-filter: Excluded by default INFO: Skipping materialyou: Excluded by default INFO: Merging inotia00-integrations-v0.115.1.apk INFO: Loading resource table... INFO: Deleting existing resource cache directory INFO: Decoding resources INFO: Decoding AndroidManifest.xml with resources... INFO: Loading resource table from file: revanced-cache/1.apk INFO: Regular manifest package... INFO: Decoding file-resources... INFO: Decoding values */* XMLs... INFO: Executing patches INFO: Bypass ambient mode restrictions succeeded INFO: Change homepage succeeded INFO: Custom branding YouTube name succeeded INFO: Custom branding icon Revancify red succeeded INFO: Custom double tap length succeeded INFO: Custom package name succeeded INFO: Custom playback speed succeeded INFO: Custom seekbar color succeeded INFO: Default playback speed succeeded INFO: Default video quality succeeded INFO: Disable QUIC protocol succeeded INFO: Disable Shorts on startup succeeded INFO: Disable auto captions succeeded INFO: Disable haptic feedback succeeded INFO: Disable hdr video succeeded INFO: Disable pip notification succeeded INFO: Enable compact controls overlay succeeded INFO: Enable external browser succeeded INFO: Enable minimized playback succeeded INFO: Enable new comment popup panels succeeded INFO: Enable new splash animation succeeded INFO: Enable new thumbnail preview succeeded INFO: Enable old quality layout succeeded INFO: Enable open links directly succeeded INFO: Enable seekbar tapping succeeded INFO: Enable tablet mini player succeeded INFO: Enable tablet navigation bar succeeded INFO: Enable time stamps speed succeeded INFO: Enable wide search bar succeeded INFO: Force OPUS codec succeeded INFO: Force VP9 codec succeeded INFO: Header switch succeeded INFO: Hide account menu succeeded INFO: Hide auto player popup panels succeeded INFO: Hide autoplay button succeeded INFO: Hide autoplay preview succeeded INFO: Hide button container succeeded INFO: Hide captions button succeeded INFO: Hide cast button succeeded INFO: Hide category bar succeeded INFO: Hide channel avatar section succeeded INFO: Hide channel watermark succeeded INFO: Hide collapse button succeeded INFO: Hide comment component succeeded INFO: Hide crowdfunding box succeeded INFO: Hide description components succeeded INFO: Hide end screen cards succeeded INFO: Hide end screen overlay succeeded INFO: Hide feed flyout panel succeeded INFO: Hide filmstrip overlay succeeded INFO: Hide floating microphone succeeded INFO: Hide fullscreen panels succeeded INFO: Hide general ads succeeded INFO: Hide handle succeeded INFO: Hide info cards succeeded INFO: Hide latest videos button succeeded INFO: Hide layout components succeeded INFO: Hide load more button succeeded INFO: Hide mix playlists succeeded INFO: Hide music button succeeded INFO: Hide navigation buttons succeeded INFO: Hide navigation label succeeded INFO: Hide player button background succeeded INFO: Hide player flyout panel succeeded INFO: Hide player overlay filter succeeded INFO: Hide previous next button succeeded INFO: Hide quick actions succeeded INFO: Hide seek message succeeded INFO: Hide seekbar succeeded INFO: Hide shorts components succeeded INFO: Hide snack bar succeeded INFO: Hide speed overlay succeeded INFO: Hide suggested actions succeeded INFO: Hide suggested video overlay succeeded INFO: Hide suggestions shelf succeeded INFO: Hide time stamp succeeded INFO: Hide tooltip content succeeded INFO: Hide trending searches succeeded INFO: Hide video ads succeeded INFO: Language switch succeeded INFO: Layout switch succeeded INFO: MicroG support succeeded INFO: Optimize resource succeeded INFO: Overlay buttons succeeded INFO: Return YouTube Dislike succeeded INFO: Settings succeeded INFO: Sponsorblock succeeded INFO: Spoof app version succeeded INFO: Spoof player parameters succeeded INFO: Swipe controls succeeded INFO: Theme succeeded INFO: Translations succeeded INFO: Compiling resources INFO: Writing modified dex files INFO: Aligning base.apk to base-Revanced-Extended_aligned.apk INFO: Signing base-Revanced-Extended_aligned.apk to base-Revanced-Extended_signed.apk INFO: Found existing keystore: revancify.keystore INFO: Copying base-Revanced-Extended_signed.apk to base-Revanced-Extended.apk INFO: Cleaned up cache directory INFO: Finished Rooted: false Arch: arm64-v8a App: YouTube v18.30.37 CLI: inotia00-cli-v2.22.2.jar Patches: inotia00-patches-v2.187.1.jar Integrations: inotia00-integrations-v0.115.1.apk Patches argument: -i bypass-ambient-mode-restrictions -i change-homepage -i custom-branding-youtube-name -i custom-branding-icon-revancify-red -i custom-double-tap-length -i custom-package-name -i custom-playback-speed -i custom-seekbar-color -i default-playback-speed -i default-video-quality -i disable-quic-protocol -i disable-shorts-on-startup -i disable-auto-captions -i disable-haptic-feedback -i disable-hdr-video -i disable-pip-notification -i enable-compact-controls-overlay -i enable-external-browser -i enable-minimized-playback -i enable-new-comment-popup-panels -i enable-new-splash-animation -i enable-new-thumbnail-preview -i enable-old-quality-layout -i enable-open-links-directly -i enable-seekbar-tapping -i enable-tablet-mini-player -i enable-tablet-navigation-bar -i enable-time-stamps-speed -i enable-wide-search-bar -i force-opus-codec -i force-vp9-codec -i header-switch -i hide-account-menu -i hide-auto-player-popup-panels -i hide-autoplay-button -i hide-autoplay-preview -i hide-button-container -i hide-captions-button -i hide-cast-button -i hide-category-bar -i hide-channel-avatar-section -i hide-channel-watermark -i hide-collapse-button -i hide-comment-component -i hide-crowdfunding-box -i hide-description-components -i hide-end-screen-cards -i hide-end-screen-overlay -i hide-feed-flyout-panel -i hide-filmstrip-overlay -i hide-floating-microphone -i hide-fullscreen-panels -i hide-general-ads -i hide-handle -i hide-info-cards -i hide-latest-videos-button -i hide-layout-components -i hide-load-more-button -i hide-mix-playlists -i hide-music-button -i hide-navigation-buttons -i hide-navigation-label -i hide-player-button-background -i hide-player-flyout-panel -i hide-player-overlay-filter -i hide-previous-next-button -i hide-quick-actions -i hide-seek-message -i hide-seekbar -i hide-shorts-components -i hide-snack-bar -i hide-speed-overlay -i hide-suggested-actions -i hide-suggested-video-overlay -i hide-suggestions-shelf -i hide-time-stamp -i hide-tooltip-content -i hide-trending-searches -i hide-video-ads -i language-switch -i layout-switch -i microg-support -i optimize-resource -i overlay-buttons -i return-youtube-dislike -i settings -i sponsorblock -i spoof-app-version -i spoof-player-parameters -i swipe-controls -i theme -i translations ```
decipher3114 commented 1 year ago

@Spacellary As you can see at the bottom of the patchlogs, the passed argument for the icon is what you have chosen. and I don't think I did any change to the argument parser yet.

Spacellary commented 1 year ago

It seemed to be an issue when Saving the patch selection that I can't reproduce anymore so it's fine then, could have been an oversight on my part and how I interacted with the Terminal User Interface.

Cheers Decipher~