declension / squeeze-alexa

Squeezebox integration for Amazon Alexa
GNU General Public License v3.0
59 stars 20 forks source link

Connection errors misreport the command #109

Closed declension closed 5 years ago

declension commented 5 years ago

Steps

Somehow disconnect the transport (maybe disconnect the broker connection, or something - that happening too much is a separate problem).

Expected

Error message with detail about the command attempted

Actual

Error message with the Squeezebox player ID / MAC address as the "command":

Traceback (most recent call last):
File "/var/task/handler.py", line 47, in lambda_handler
return sqa.handle(event, context)
File "/var/task/squeezealexa/main.py", line 65, in handle
return super(SqueezeAlexa, self).handle(event, context)
File "/var/task/squeezealexa/alexa/handlers.py", line 49, in handle
return self.on_intent(request, session)
File "/var/task/squeezealexa/main.py", line 90, in on_intent
return intent_handler(self, intent, session, pid=pid)
File "/var/task/squeezealexa/main.py", line 306, in on_play_playlist
server.playlist_resume(pl, player_id=pid)
File "/var/task/squeezealexa/squeezebox/server.py", line 343, in playlist_resume
self.player_request(cmd, wait=False, player_id=player_id)
File "/var/task/squeezealexa/squeezebox/server.py", line 253, in player_request
raw=raw, wait=wait)[0]
File "/var/task/squeezealexa/squeezebox/server.py", line 165, in _request
cmd=first_word, transport=self.transport))
squeezealexa.squeezebox.server.SqueezeboxException: Can't do '00:**:**:**:**:94', MQTT to client to *********.iot.eu-west-1.amazonaws.com:8883 is not connected