Can we overhaul internals of Variables

dedupeio / dedupe

:id: A python library for accurate and scalable fuzzy matching, record deduplication and entity-resolution.

https://docs.dedupe.io

MIT License

4.15k stars 551 forks source link

Can we overhaul internals of Variables #1104

Open NickCrews opened 2 years ago

NickCrews commented 2 years ago

@fgregg how open are you to backwards-incompatible changes to the way that Variables are implemented? If we could go in there and overhaul their APIs I think that might make https://github.com/dedupeio/dedupe/pull/1102 be better. Not exactly sure what I'm looking for yet.

I'm thinking of if someone has gone and subclassed Variable then this might break them.

fgregg commented 2 years ago

i'm open to big changes, but i doubt we need to make them breaking.