search

deepjyoti30 / ytmdl

A simple app to get songs from YouTube in mp3 format with artist name, album name etc from sources like iTunes, Spotify, LastFM, Deezer, Gaana etc.
https://ytmdl.deepjyoti30.dev
MIT License
3.15k stars 164 forks source link

Downloading Lyrics #223

Open ChandanShakya opened 2 years ago

ChandanShakya commented 2 years ago

Feature Request

Checklist

Description

I want to be able to have the lyrics downloaded alongside the song or manually.

deepjyoti30 commented 2 years ago

@ZXY-CC-3ag13 Most metadata providers do not provide lyrics and adding a whole different layer of provider just to fetch lyrics seems like an overkill considering most music players won't even recognize the lyrics stored as metadata.

I will keep the issue open in case more people seem to need this feature, they can discuss in this issue itself.

cowpod commented 2 years ago

spotDL manages to do this, and they download from youtube too. not sure how though, looking at ffmpeg each line is suffixed with ":". https://github.com/spotDL/spotify-downloader

deepjyoti30 commented 1 year ago

@cowpod Thanks for letting us know. Seems like spotdl gets the data from Spotify only and since Spotify recently rolled out lyrics support for all countries (afaik), that is probably the reason why spotdl is able to do it.

However, in case of ytmdl, we let users select the metadata provider and we do support a lot of providers other than spotify and I am aware that as of now only Spotify and MusicBrainz provides lyrics which brings me back to the same reason that adding support for lyrics just for one or two providers doesn't seem like it's worth it.

Also, considering the basic metadata (like title, album name, singer name) are already being fetched, I think most music players will fetch the lyrics automatically (at least ncmpcpp does this).