search

deepkit / deepkit-framework

A new full-featured and high-performance TypeScript framework
https://deepkit.io/
MIT License
3.14k stars 116 forks source link

Replace faker with a maintained version of the package #582

Open ST-DDT opened 1 week ago

ST-DDT commented 1 week ago

I noticed, that you are using the old version of faker, that is no longer maintained.

https://github.com/deepkit/deepkit-framework/blob/81a1ab1e82ae170034545a25aa540a3a7c69acd7/packages/framework/package.json#L55 https://github.com/deepkit/deepkit-framework/blob/81a1ab1e82ae170034545a25aa540a3a7c69acd7/packages/framework/package.json#L87 https://github.com/deepkit/deepkit-framework/blob/81a1ab1e82ae170034545a25aa540a3a7c69acd7/packages/create-app/files/package.json#L42

You might want to switch to the maintained package @faker-js/faker.

It has all the versions from the old package, but received numerous updates in the meantime (including built-in types).

Disclaimer: I'm a maintainer of @faker-js/faker.

marcj commented 1 week ago

@ST-DDT is the API the same?

ST-DDT commented 1 week ago

In all versions prior to v6 yes.

faker@v<6 === @faker-js/faker@v<6

v6 should have almost no API breaking changes, but a lot of stuff has been moved around internally.

faker@v5.5.3 == @faker-js/faker@v6 (+fixes +new methods +updated locale data)

Newer versions have a few breaking changes.