deeptools / HiCBrowser

Simple web browser to visualize HiC tracks
GNU General Public License v2.0
18 stars 5 forks source link

uwsgi integration #11

Open bgruening opened 7 years ago

bgruening commented 7 years ago

This branch is used in the HiCBrowser Docker image, as we are using nginx as proxy server and uwsgi as application server inside of the image.

Unfortunately, I was not able to get uwsgi and the ./runBrowserpy script working simultaneously. The app has some wired behaviors so I needed to include the main call in the views.py script.

I hope someone is more a flask expert and can help resolving this. Until than I will leave this PR open and update this branch manually with the master branch if needed.

bgruening commented 7 years ago

@fidelram this will make HiCB working under uwsgi, which is used in the Docker container and in Galaxy. Can you take a look if this breaks any of your setups, use-cases?

fidelram commented 7 years ago

With respect to views.py I don't see much problems but I have not tested them (@bgruening does it run for you?).

For the other edits I have to warn you that some of the code modified, like App.js, is generated by Node.js

Thus, ideally, such things should be removed at the source code and the the new js code should be recompiled. However, I only have a superficial understanding of how this works and the main developer is not longer available. Do you know any Node.js guru?

bgruening commented 7 years ago

I see. Yes it is working for us and it will be part of the next upcoming Galaxy release. Lets keep this open until I have more time to look at it in more different use-cases.

One thing this PR is also doing is that you can now run multiple visualizations under different sub-dirs. Like foo.eu/human and foo.eu/mouse. This will be useful for the Hein group.

fidelram commented 7 years ago

Different subdirs will be quite useful for us as well. Something that I think is not working for me in the current version is the search by gene name. Is it working for you?