Make the search query more flexible

deerawan / vscode-dash

Dash, Zeal and Velocity documentation integration in Visual Studio Code 🔎📖

MIT License

285 stars 23 forks source link

Make the search query more flexible #88

Open kneirinck opened 4 years ago

kneirinck commented 4 years ago

Changelog

Make it possible to configure the search URI and also exclude the docsets from the search query. As such you can use this extension with https://github.com/egoist/devdocs-desktop on macOS by setting the URI to devdocs://search/ and excluding the docsets.

Checklist

[x] Code compiles correctly
[x] Add or update tests, if possible
[x] All tests passing
[ ] Update the README, if necessary
[x] New contributor? added myself via npm run contributor:add

deerawan commented 4 years ago

@kneirinck Hi, thanks for submitting a PR. 💪🏼

A question from me, could we use this to open devdocs web as well?

Instead of making searchURI as free text, would it be better to make it fixed to devdocs uri?

kneirinck commented 4 years ago

A question from me, could we use this to open devdocs web as well?

Good question! I've just tested it and it does indeed, but it can be done for any website I guess.

Instead of making searchURI as free text, would it be better to make it fixed to devdocs uri?

Well the devdocs macos application uses devdocs://search/, the website version would use https://devdocs.io/#q=. So I don't think having some fixed option here is possible?