deestar12 / keeperfx

Automatically exported from code.google.com/p/keeperfx
0 stars 0 forks source link

Are you sure switching to FFmpeg decoder is a good idea? #616

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Mefisto, I am trying to use FFmpeg decoder that you mentioned to play movies 
instead of Smacker library. I found that if this is done, the the game is 
likely to require FFmpeg installed to successfully play movies. Otherwise we 
will need to include those dlls like 'avfotmat-56.dll' ourselves. This doesn't 
look better than SMACKW32.dll to me.

Are you sure the change is benefitial? What is the merit of using FFmpeg 
deocder over SMACKW32?

Original issue reported on code.google.com by HeMeng86@gmail.com on 14 May 2015 at 1:24

GoogleCodeExporter commented 8 years ago
Smacker is a commercial library, so we have to get rid of it sooner or later.
Also, it's designed to be used with Miles Sound System, which we will also 
remove.

We definitely don't need everything which comes with FFmpeg. We only need a SMK 
player. We need to cut the library to make it relatively light. We may also use 
different open-source SMK player, if you are able to find one.

Original comment by mefistotelis on 14 May 2015 at 2:31

GoogleCodeExporter commented 8 years ago
Thinking about it a bit more, there is a possibility to convert all videos to 
different format and get rid of SMK completely...

Since KeeperFX already generates almost all its graphics files (and will change 
their format soon), we don't have anything to gain anymore by sticking to SMK 
format.

Original comment by mefistotelis on 14 May 2015 at 4:37

GoogleCodeExporter commented 8 years ago
Will that will make the decode easier?

Currently I got pictures from Smacker file, working to bilt them to screen.

Original comment by HeMeng86@gmail.com on 15 May 2015 at 2:57

GoogleCodeExporter commented 8 years ago
converting Libav frame to SDL_texture is a little hacky. If changing file 
format can work around this, please decide in early time.

Original comment by HeMeng86@gmail.com on 15 May 2015 at 3:21

GoogleCodeExporter commented 8 years ago
I don't really feel the need to change the format. We may decide to do so if 
there are serious problems with implementing it, ie. the existing libraries 
will prove to be immature or lack enough control over the playback. Otherwise, 
SMK may stay.

Also, I've found a wiki link to another library, which may be easier to 
integrate into current solution - check if if you want; if not, FFmpeg is good 
for me.
http://libsmacker.sourceforge.net/

The advantage of having FFmpeg is that we may easily add support of other 
formats later. Also, FFmpeg is likely to have future development, updates etc.

Original comment by mefistotelis on 18 May 2015 at 10:01

GoogleCodeExporter commented 8 years ago
I also saw this library before, but are you sure about the license part?  We 
have to be sure it is not another smacker32.

Original comment by HeMeng86@gmail.com on 18 May 2015 at 3:40

GoogleCodeExporter commented 8 years ago
The license doesn't make much difference for me.

Anyway, I think FFmpeg would be better solution.

Also, I'm not sure if I tried libsmacker before... it is possible I had a 
reason to turn for FFmpeg, but I don't have any documentation for it. Are you 
sure libsmacker is capable of playing DK movies correctly?

Original comment by mefistotelis on 18 May 2015 at 3:54

GoogleCodeExporter commented 8 years ago
No, I have seen the page but never actually tried the library.

Original comment by HeMeng86@gmail.com on 18 May 2015 at 3:56

GoogleCodeExporter commented 8 years ago

Original comment by HeMeng86@gmail.com on 29 May 2015 at 5:00