search

defano / wyldcard

A clone of Apple's HyperCard and HyperTalk scripting language.
https://github.com/defano/wyldcard/wiki
MIT License
117 stars 12 forks source link

"The version" does not resolve #96

Closed ooper-zz closed 2 years ago

ooper-zz commented 2 years ago

When importing stacks that use the version property (e.g. FocalPoint II) do not resolve. I realize that old stacks are referring to HyperCard, but perhaps we can assume that any stack that is importable (HC 2.x) should return our baseline version (2.4 as documented). At this point, that function doesn't even return WyldCard's version.

defano commented 2 years ago

Agreed. Adding a new zero-arg function the version that just returns new Value("2.4.1"); should be pretty easy. Wanna submit a PR for that? Otherwise I can get it in sometime this week.

ooper-zz commented 2 years ago

Thanks for taking a look. I'll add a PR for that. It's a perfect one to take on, so that I get more intimate with the software. If you can give me some pointers, it would be even better.

Mark, I can be reached at @.*** I think it would be awesome to have a quick chat about the future of wyldCard. If you send me an email there, I can give you my phone #, so it doesn't end up here in the wild.

Looking forward, Carl

From: Matt DeFano @.> Sent: Tuesday, May 17, 2022 1:14 PM To: defano/wyldcard @.> Cc: Carl Garcia @.>; Author @.> Subject: Re: [defano/wyldcard] "The version" does not resolve (Issue #96)

Agreed. Adding a new zero-arg function the version that just returns new Value("2.4.1"); should be pretty easy. Wanna submit a PR for that? Otherwise I can get it in sometime this week.

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdefano%2Fwyldcard%2Fissues%2F96%23issuecomment-1129275981&data=05%7C01%7C%7C200cae9677d14efcc30508da3841d0da%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637884152568946995%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=x%2B6d2wJzJ7OZrFpfeJ29YI40rbZuBtc5idHYQS3lAeU%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAZ473WNAUEQTVCI2YMDN6LVKP4ZNANCNFSM5WGB3LTA&data=05%7C01%7C%7C200cae9677d14efcc30508da3841d0da%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637884152568946995%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=bQrr%2BeWW6uO9v9IOae428h3qryj9zWDdulHbqdZIY0k%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

ooper-zz commented 2 years ago

I figured it out following the pattern of another no-arg function. Easy enough, but I broke some tests and will follow up tomorrow. TTYL

defano commented 2 years ago

I don't think Github wants you sharing your email address :) It's been redacted.

Nevertheless, it's probably easier for me to respond in this forum, anyway, plus it's then visible for others who might want to contribute or have the same questions, too.

If you like, open a new issue like "Future of WyldCard" or "Questions about design" and we can go back-and-forth in writing.

ooper-zz commented 2 years ago

I noticed the redaction --for the better, no doubt. Great points! I added an issue "Discussions:Future of WyldCard" and will add some questions and basic assertions. I guess we can set the forum towards a FAQ and Road Map section from there...

ooper-zz commented 2 years ago

Hey, I have submitted comments for my fixes and have them checked in on my Forked master branch, but please let me know how to proceed with the new pull request, as I am not a regular GitHub user. Also, I made a small change to the HyperCard 2.4.1 version function, as it returns "2.41", not "2.4.1". Thanks!

defano commented 2 years ago

Your recent change looks good. Simply updating the branch that is open for review implicitly updates the PR, too. I have merged. Thanks for that change!