defenseunicorns / uds-common

Common framework for UDS Packages
GNU Affero General Public License v3.0
6 stars 7 forks source link

wip: rollup issue for DD 04-24 #109

Open Noxsios opened 7 months ago

Noxsios commented 7 months ago

Place for me to put notes / issues about uds-common as they come up. Pay no attention until DD is over please.

Noxsios commented 7 months ago

K3D is a hard requirement https://github.com/defenseunicorns/uds-common/blob/main/.github/actions/setup/action.yaml and does not have an associated install task

Noxsios commented 7 months ago

Docs for uds deploy commands show should have --confirm. I think the user persona is more geared towards people familiar w/ k8s and deployments.

CI should fail if CI=true and --confirm=false

Noxsios commented 7 months ago

~Is uds deploy k3d-core-slim-dev:0.18.0 actually tested in any workflow?~

~https://github.com/defenseunicorns-dashdays/increase-shareholder-value/actions/runs/8655604135/job/23734817108~

Noxsios commented 7 months ago

k3d-test-cluster sets up a k3d cluster running the uds-core-istio-dev package. This provides a baseline cluster with Istio and the UDS Core Pepr capabilities necessary to test against.

package is actually a bundle, and bundle referenced does not exist, actual upstream is k3d-core-slim-dev