Fix: made pre-commit check pass - Githubissues

defenseunicorns / uds-package-mattermost

🏭 UDS Mattermost Zarf Package

GNU Affero General Public License v3.0

5 stars 3 forks source link

Fix: made pre-commit check pass #107

Closed JoeHCQ1 closed 4 months ago

JoeHCQ1 commented 4 months ago

Description

Made formatting and other minor changes to get pre-commit run --all-files to pass. Biggest changes were:

Exempted whole charts/templates directory from yaml check because everywhere there was helm templating it broke.
Added namespace declaration to zarf.yaml charts spec per schema requirement.

Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[X] Test, docs, adr added or updated as needed
[X] Contributor Guide Steps followed

JoeHCQ1 commented 4 months ago

Closing this per the above discussion points:

We're removing the pre commit hook file instead of conforming to it in preference for other quality checks.
The SVG got modified somehow.
The namespace change shouldn't have been required by the schema and should be fixed upstream to be optional.