degeron / qmmp

Automatically exported from code.google.com/p/qmmp
0 stars 0 forks source link

plugin-pack: QSUI anyway built #631

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
On CMake build of qmmp-plugin-pack, even if QSUI plugin is disabled,
by specifying -DUSE_QSUI:BOOL=FALSE for cmake argument, all sources
under src/Ui/qsui/ would be built, after the message
'Simple UI plugin ................disabled' on the configuration
procedure.  If this behaviour is not expected, please fix it.

Index: qmmp-plugin-pack/src/Ui/CMakeLists.txt
===================================================================
--- qmmp-plugin-pack/src/Ui/CMakeLists.txt      (revision 4036)
+++ qmmp-plugin-pack/src/Ui/CMakeLists.txt      (working copy)
@@ -1,6 +1,6 @@
 SET(USE_QSUI TRUE CACHE BOOL "enable/disable simple ui")

-IF(QMMP_FOUND AND QMMPUI_FOUND)
+IF(USE_QSUI AND QMMP_FOUND AND QMMPUI_FOUND)
 add_subdirectory(qsui)
-ENDIF(QMMP_FOUND AND QMMPUI_FOUND)
+ENDIF(USE_QSUI AND QMMP_FOUND AND QMMPUI_FOUND)

===================================================================

Note that QMake build handles SIMPLE_UI_PLUGIN fine.

Original issue reported on code.google.com by liangtai...@gmail.com on 17 Jan 2014 at 5:08

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r4041.

Original comment by trialuser02 on 17 Jan 2014 at 8:16

GoogleCodeExporter commented 9 years ago
Fixed in svn. Thank you!

Original comment by trialuser02 on 17 Jan 2014 at 8:16