deis / builder

Git server and application builder for Deis Workflow

https://deis.com

MIT License

40 stars 41 forks source link

ref(probes): move k8s probe from liveness into readiness #334

Closed kmala closed 8 years ago

kmala commented 8 years ago

Summary of Changes

add probe to check the status of the controller

Issue(s) that this PR Closes

Closes #181

Associated End To End Test PR(s)

Associated Documentation PR(s)

Associated Design Document(s)

Testing Instructions

Please provide a detailed list for how to test the changes in this PR.

Create a Deis Cluster
check the status of the builder and it should be serving
now stop the controller and check the status of the builder, it should still be up but not ready to serve requests
Pull Request Hygiene TODOs

Please make sure the below checklist is complete.

[x] Your pull request is concise and to the point (make another PR for refactoring nearby code)
[x] Your commits are squashed into logical units of work
[x] Your commits follow the commit style guidelines