deis / builder

Git server and application builder for Deis Workflow

https://deis.com

MIT License

40 stars 41 forks source link

Update pkg/gitreceive/config.go w/ v2.0.0 tags #357

Closed vdice closed 8 years ago

vdice commented 8 years ago

Summary

Once the v2.0.0 milestone is closed (v2.0.0 released), the following values need to be updated to point to the appropriate Docker image tags.

bacongobbler commented 8 years ago

so v2.0.0 has been using pre-prod slugbuilder/dockerbuilder for a while now? yeesh. Fixing this now.

bacongobbler commented 8 years ago

Ah I'm mistaken; the chart overrides this so this has been fine.

arschles commented 8 years ago

@bacongobbler why not remove the defaults entirely and make those values required? Doing so would remove confusion and we wouldn't have to update them in the future

helgi commented 8 years ago

In the Controller we just reference canary :P

bacongobbler commented 8 years ago

Indeed. I think that is the better approach. I will amend #376 to do so.