search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

chore(Dockerfile): bump git to v2.8.4 #364

Closed bacongobbler closed 8 years ago

bacongobbler commented 8 years ago

closes #362 closes deis/deis#5031

bacongobbler commented 8 years ago

closing/re-opening to bump jenkins

codecov-io commented 8 years ago

Current coverage is 41.76%

Merging #364 into master will decrease coverage by 0.27%

@@             master       #364   diff @@
==========================================
  Files            24         24          
  Lines          1111       1111          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            467        464     -3   
- Misses          620        623     +3   
  Partials         24         24

Powered by Codecov. Last updated by d7f04fc...72638a9

helgi commented 8 years ago

2.9 is out

bacongobbler commented 8 years ago

let's bump it once we audit 2.9. For now this fixes some critical issues and I have not seen any upgrade problems from 2.7 to 2.8 :)

krancour commented 8 years ago

If I am not mistaken, newer versions of git are usually available from git's own ppa. Installing from there would spare us from building from source and from all the cleanup that must necessarily follow that to keep images small.

bacongobbler commented 8 years ago

If I am not mistaken, newer versions of git are usually available from git's own ppa. Installing from there would spare us from building from source and from all the cleanup that must necessarily follow that to keep images small.

Do you feel that's something we need to do in this PR or just a passing comment? :)

mboersma commented 8 years ago

newer versions of git are usually available from git's own ppa

It would be cleaner and safer IMHO to use the official package, agreed. I'm ok with building from source, but if there is time to refactor this PR I think @krancour has a good point.

bacongobbler commented 8 years ago

let's refactor later and just get v2.8.4 out the door so we can close this security loophole. I'll file a ticket to reafactor how we build git