deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

fix(pkg): set check timeouts to 10s #373

Closed mboersma closed 8 years ago

mboersma commented 8 years ago

Summary of Changes

Changes the healthcheck/readiness check internal timeout value to 10 seconds, to match the values used in the Workflow charts.

Issue(s) that this PR Closes

This is one change of several that seem to ameliorate readiness check misbehavior under load. It doesn't fix the situation on its own but does seem to help.

Refs deis/workflow-e2e#215.

Pull Request Hygiene TODOs

deis-bot commented 8 years ago

@arschles and @kmala are potential reviewers of this pull request based on my analysis of git blame information. Thanks @mboersma!

codecov-io commented 8 years ago

Current coverage is 41.85%

Merging #373 into master will not change coverage

@@             master       #373   diff @@
==========================================
  Files            24         24          
  Lines          1111       1111          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            465        465          
  Misses          622        622          
  Partials         24         24          

Powered by Codecov. Last updated by 567e8c8...844b2ff