search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

chore(rootfs): bump slugbuilder/dockerbuilder images to v2.1.0 #376

Closed bacongobbler closed 8 years ago

bacongobbler commented 8 years ago

relies on the v2.1.0 release images being published.

closes #357

deis-bot commented 8 years ago

@kmala, @krancour and @aledbf are potential reviewers of this pull request based on my analysis of git blame information. Thanks @bacongobbler!

helgi commented 8 years ago

These defaults are a little dangerous in general :|

bacongobbler commented 8 years ago

These defaults are a little dangerous in general :|

Could you elaborate on what makes these dangerous? Just the fact that we're pinning the image names or something else?

helgi commented 8 years ago

That we pin them and they get forgotten, because we update things up in the charts

bacongobbler commented 8 years ago

going to punt this to v2.2. This is not the approach we want to take, and is not a serious issue since the chart overrides this value. Instead we're just going to make this envvar a requirement so then we only have to reference this in one place.

bacongobbler commented 8 years ago

377 fixes this