search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

docs(github): simplify github templates #383

Closed bacongobbler closed 8 years ago

bacongobbler commented 8 years ago

We've found that half of the engineering team either hates or doesn't even bother using the PR templates. Refactoring it down to the bare minimum should suffice.

deis-bot commented 8 years ago

@arschles is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @bacongobbler!

arschles commented 8 years ago

@bacongobbler could we leave a small section that prompts contributors to think about documentation at least? the deisrel PR template might be a good model to follow. note that I have no data to back up any of these claims - just a guess

codecov-io commented 8 years ago

Current coverage is 41.66%

Merging #383 into master will increase coverage by 0.08%

@@             master       #383   diff @@
==========================================
  Files            25         25          
  Lines          1140       1140          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            474        475     +1   
+ Misses          638        637     -1   
  Partials         28         28

Powered by Codecov. Last updated by 80d8cf9...33405a7

bacongobbler commented 8 years ago

That's a good suggestion. I've been trying to hack on simplifying down the templates to the "bare minimum". Making a two-line template to reference related doc or e2e PRs would be simple enough.

bacongobbler commented 8 years ago

okay, that should simplify things!