feat(builder): delete cache if the cache is disabled

deis / builder

Git server and application builder for Deis Workflow

https://deis.com

MIT License

40 stars 41 forks source link

feat(builder): delete cache if the cache is disabled #422

Closed Joshua-Anderson closed 8 years ago

Joshua-Anderson commented 8 years ago

cc @jeroenvisser101

If DEIS_DISABLE_CACHE is set and the cache file exists, delete the cache.

deis-bot commented 8 years ago

@jeroenvisser101, @arschles and @aledbf are potential reviewers of this pull request based on my analysis of git blame information. Thanks @Joshua-Anderson!

jeroenvisser101 commented 8 years ago

Few remarks, but overal, this LGTM.

codecov-io commented 8 years ago

Current coverage is 46.60% (diff: 36.84%)

Merging #422 into master will decrease coverage by 0.50%

@@             master       #422   diff @@
==========================================
  Files            26         26          
  Lines          1106       1118    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            521        521          
- Misses          554        566    +12   
  Partials         31         31

Powered by Codecov. Last update c776995...df0183d

mboersma commented 8 years ago

Set/unset is ok with me, since we did create a precedent for it with the deployments feature flag.