search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

ref(ssh keys): remove support for DSA #493

Closed vdice closed 7 years ago

vdice commented 7 years ago

Ref https://github.com/golang/go/issues/19424

A potential fix/solution for https://github.com/deis/builder/issues/462 (need further testing/deployment into clusters to be sure)

deis-bot commented 7 years ago

@bacongobbler is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @vdice!

codecov-io commented 7 years ago

Codecov Report

Merging #493 into master will decrease coverage by 0.08%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   55.93%   55.85%   -0.09%     
==========================================
  Files          29       29              
  Lines        1221     1221              
==========================================
- Hits          683      682       -1     
- Misses        500      501       +1     
  Partials       38       38
Impacted Files Coverage Δ
pkg/sshd/server.go 55% <0%> (ø) :white_check_mark:
pkg/healthsrv/circuit_state.go 77.77% <0%> (-11.12%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c20e962...e0765bf. Read the comment docs.

vdice commented 7 years ago

This has been running on a personal GKE cluster since this morning and panic described in https://github.com/deis/builder/issues/462 has not been encountered; we've recently deployed to our dogfood cluster as well. Aside from the user ramifications (looking for community/user feedback on that detail), this may be a path forward...

Bregor commented 7 years ago

Is there any instructions on how to build/install?

vdice commented 7 years ago

Is there any instructions on how to build/install?

Good question, apologies for not mentioning. For others who would like to apply patch, simply kubectl -n deis edit deploy deis-builder and swap in quay.io/deisci/builder:git-e0765bf for the image.

Bregor commented 7 years ago

Also you can use set instead of edit:

$ kubectl -n deis set image deployment deis-builder deis-builder=quay.io/deisci/builder:git-e0765bf
vdice commented 7 years ago

Closes https://github.com/deis/builder/issues/462

Bregor commented 7 years ago 
$ kubectl get po -n deis | head -2
NAME                                     READY     STATUS    RESTARTS   AGE
deis-builder-1727066652-mhq1s            1/1       Running   0          2d

It's a miracle! ;)

bacongobbler commented 7 years ago

I'm all for this if it fixes things. LGTM.

mboersma commented 7 years ago

I think removing the DSA key support is a small price to pay for fixing this pernicious bug.