search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

feat(ingress) Experimental Native Ingress #495

Closed krisnova closed 7 years ago

krisnova commented 7 years ago

Adds LoadBalancer to builder if we are using EXPERIMENTAL_NATIVE_INGRESS

Requires deis/controller#1243 Requires deis/workflow#732 Requires https://github.com/deis/router/pull/316

codecov-io commented 7 years ago

Codecov Report

Merging #495 into master will decrease coverage by 0.08%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
- Coverage   56.42%   56.34%   -0.09%     
==========================================
  Files          29       29              
  Lines        1237     1237              
==========================================
- Hits          698      697       -1     
- Misses        501      502       +1     
  Partials       38       38
Impacted Files Coverage Δ
pkg/healthsrv/circuit_state.go 77.77% <0%> (-11.12%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4634fe1...9a2a1b4. Read the comment docs.

krisnova commented 7 years ago

@bacongobbler nit has been fixed 😄

krisnova commented 7 years ago

So this is all rebased and ready to go methinks..

The only thing it looks like we are missing is the fact that test coverage went down here. But I am not really sure what we would do in a situation like this as we are only really adding YAML configuration and not really any code here.

@mboersma thoughts?

mboersma commented 7 years ago

test coverage went down here

Probably just the vagaries of codecov--the YAML files aren't relevant obviously, and there isn't a unit test we could write to cover the LoadBalancer change anyway.