deis / builder

Git server and application builder for Deis Workflow

https://deis.com

MIT License

40 stars 41 forks source link

RBAC support #513

Closed Bregor closed 7 years ago

Bregor commented 7 years ago

With this change deis-builder became available to work in RBAC-only clusters

Works with both Kubernetes 1.5 and 1.6 (see templates/_helpers.tmpl for details) Actually tested with 1.5.7 and 1.6.2

Role allows deis-builder:

secrets: create, update and delete
pods: get, list, watch and create
pods/log: get

ClusterRole allows deis-builder:

namespaces: list

deis-admin commented 7 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

vdice commented 7 years ago

Jenkins, OK to test

codecov-io commented 7 years ago

Codecov Report

Merging #513 into master will decrease coverage by 0.08%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
- Coverage   56.53%   56.45%   -0.09%     
==========================================
  Files          29       29              
  Lines        1240     1240              
==========================================
- Hits          701      700       -1     
- Misses        501      502       +1     
  Partials       38       38

Impacted Files	Coverage Δ
pkg/healthsrv/circuit_state.go	`77.77% <0%> (-11.12%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6403e7...ce77ee6. Read the comment docs.

vdice commented 7 years ago

Jenkins, add to whitelist

mboersma commented 7 years ago

Jenkins, add to whitelist.