search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

feat(builder): adjust dockerbuilder and slugrunner templates #74

Closed smothiki closed 8 years ago

smothiki commented 8 years ago

Modify dockerbuilder and slugbuilder templates if the secret is not present.

arschles commented 8 years ago

@smothiki do we want to support running object storage without auth? IMO the answer is no, do you have a use case?

smothiki commented 8 years ago

For fetcher which runs with out auth for now. Also if we want to give customizable storage solutions or outside storage which doesn't have auth then this will be helpful

arschles commented 8 years ago

For fetcher which runs with out auth for now

We agreed that Fetcher is gonna go away (#6)

Also if we want to give customizable storage solutions or outside storage which doesn't have auth then this will be helpful

IMO we shouldn't encourage anyone to run object storage (especially not outside storage, but also in-cluster storage) without auth

smothiki commented 8 years ago

In this PR I'm just fixing secrets as we have changed from object-store to minio-user. If we are thinking enforcing auth strictly I'll create different PR

arschles commented 8 years ago

Ok, makes sense. I assumed wrong about what this PR was going to be. Sorry for jumping the gun, and let me know when you're ready for a review.

smothiki commented 8 years ago

I have tested it and commands are working this PR ready for a review