search

deis / workflow

The open source PaaS for Kubernetes.
https://deis.com/workflow/
MIT License
1.31k stars 181 forks source link

use helm selective installs #737

Closed bacongobbler closed 7 years ago

bacongobbler commented 7 years ago

in the charts, we have a lot of {{ if eq .Values.globals.registry_location "on-cluster" }} everywhere. We should use the new Helm v2.2.0 conditional field feature.

https://github.com/kubernetes/helm/blob/master/docs/charts.md#tags-and-condition-fields-in-requirementsyaml

bacongobbler commented 7 years ago

This would also require that we have to make Helm v2.2.0 the minimum version for installing, so we'd need to take care of that in the docs as well.

bacongobbler commented 7 years ago

closing in favour of #771