search

dej611 / spid-react-button

Pulsante SSO per SPID in React
https://dej611.github.io/spid-react-button/
European Union Public License 1.2
18 stars 15 forks source link

Update CI NodeMatrix to include all Supported Versions #71

Closed catrielmuller closed 2 years ago

catrielmuller commented 2 years ago

Node 10 was deprecated on Apr of 2021(https://endoflife.date/nodejs) this is an update of the CI to run on the all supported NodeJS versions.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dej611/spid-react-button/FSjmtEZBGNyknihw7PW6YemjSCDA
✅ Preview: https://spid-react-button-git-fork-catrielmuller-catriel-a613bb-dej611.vercel.app

dej611 commented 2 years ago

Good catch with that travis file: actually that is not used at all in this repo 😅 .

If you could change the Node version in the Github workflows would be very appreciated tho: https://github.com/dej611/spid-react-button/tree/main/.github/workflows

Even just bump it to the latest Node 14 version would be super useful.

catrielmuller commented 2 years ago

Good catch with that travis file: actually that is not used at all in this repo sweat_smile .

If you could change the Node version in the Github workflows would be very appreciated tho: https://github.com/dej611/spid-react-button/tree/main/.github/workflows

Even just bump it to the latest Node 14 version would be super useful.

Was, funny because I create this PR because I received an Email of Travis that my Branch Fail (Because I have configured all my public repositories)

I Updated the GHActions Workflow script to move to Node16 on the final production Build and keep a matrix with 14 and 16 to check the compatibility there. Node17 it's pretty new so almost all projects fails there, however now it's easy to add into the matrix. LMK if look good to you.