dell / csm

Dell Container Storage Modules (CSM)
Apache License 2.0
69 stars 15 forks source link

[BUG]: prometheus-values.yaml error in json #259

Closed DougBernhardt closed 2 years ago

DougBernhardt commented 2 years ago

Bug Description

When using the provided prometheus-values.yaml to install prometheus I get the following error: Error: INSTALLATION FAILED: failed to parse prometheus-values.yaml: error converting YAML to JSON: yaml: line 24: did not find expected key

Logs

helm install prometheus prometheus-community/prometheus -n karavi -f prometheus-values.yaml Error: INSTALLATION FAILED: failed to parse prometheus-values.yaml: error converting YAML to JSON: yaml: line 24: did not find expected key

Screenshots

No response

Additional Environment Information

prometheus-values.yaml

alertmanager: enabled: false nodeExporter: enabled: false pushgateway: enabled: false kubeStateMetrics: enabled: false configmapReload: prometheus: enabled: false server: enabled: true image: repository: quay.io/prometheus/prometheus tag: v2.23.0 pullPolicy: IfNotPresent persistentVolume: enabled: false service: type: NodePort servicePort: 9090 extraScrapeConfigs: |

Steps to Reproduce

use provided yaml in install instructions helm install prometheus prometheus-community/prometheus -n karavi -f prometheus-values.yaml

Expected Behavior

should deploy

CSM Driver(s)

CSM Module for PowerStore

Installation Type

Helm

Container Storage Modules Enabled

Observability

Container Orchestrator

Kubernetes v1.23.5

Operating System

RHEL 8.5

hoppea2 commented 2 years ago

@DougBernhardt Thank you for your submission, we are going to triage this and update the ticket

shaynafinocchiaro commented 2 years ago

@DougBernhardt Can you provide the version of the CSI PowerStore driver and the version of the Observability module that you are using?

DougBernhardt commented 2 years ago

dellemc/csm-metrics-powerstore:v1.1.0

shaynafinocchiaro commented 2 years ago

Hi @DougBernhardt Please update your prometheus-values.yaml to reflect this format:

alertmanager: enabled: false nodeExporter: enabled: false pushgateway: enabled: false kubeStateMetrics: enabled: false configmapReload: prometheus: enabled: false server: enabled: true image: repository: quay.io/prometheus/prometheus tag: v2.23.0 pullPolicy: IfNotPresent persistentVolume: enabled: false service: type: NodePort servicePort: 9090 extraScrapeConfigs: |

This will resolve the parsing errors you're seeing. You may also want to change the job name to match the driver you're using so that it is properly reflected in the prometheus UI, but this is only a suggestion.